Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some update tests failing #531

Closed
JDGrimes opened this issue Oct 3, 2016 · 5 comments
Closed

Some update tests failing #531

JDGrimes opened this issue Oct 3, 2016 · 5 comments
Assignees
@JDGrimes
Labels
bug
Milestone
2.2.0

Comments

@JDGrimes
Copy link
Member

JDGrimes commented Oct 3, 2016

See https://travis-ci.org/WordPoints/wordpoints/jobs/159920235#L377 for example.
@JDGrimes JDGrimes added the bug label Oct 3, 2016
@JDGrimes JDGrimes added this to the 2.2.0 milestone Oct 3, 2016
@JDGrimes
Copy link
Member Author

JDGrimes commented Oct 3, 2016

I should note that this only occurs when the tests are run with WordPoints network activated. I have a feeling that it is related to WordPoints/dev-lib#161.

@JDGrimes
Copy link
Member Author

JDGrimes commented Oct 3, 2016

The uninstall and Ajax tests are also failing on multisite. Possibly related.

@JDGrimes JDGrimes self-assigned this Oct 3, 2016
@JDGrimes
Copy link
Member Author

JDGrimes commented Oct 3, 2016

Apparently this is caused by get_site_transient( 'wordpoints_all_site_ids' ) returning array( 1 ) instead of all of the sites that were created for the test being run. This is indeed due to changes relating to WordPoints/dev-lib#161, since WordPoints is now being loaded normally, rather than via wordpointstests_manually_load_plugin(), which used to delete this transient.

@JDGrimes
Copy link
Member Author

JDGrimes commented Oct 3, 2016

The issue with the uninstall (and presumably Ajax) tests appears to be separate.

@JDGrimes JDGrimes mentioned this issue Oct 3, 2016
Closed
@JDGrimes
Copy link
Member Author

JDGrimes commented Oct 4, 2016

For posterity, the issue with the Ajax tests was fixed in WordPoints/dev-lib#179.

JDGrimes added a commit that referenced this issue Oct 4, 2016
@JDGrimes
Update including of WP_Filesystem_Base
3a43987 
We've updated the wp-filesystem-mock package recently, to take advantage of its improved autoloading compatibility. So we now no longer need to manually include those classes, or even check if they exist. However, the filesystem mock package no longer automatically includes the base filesystem class, so we need to include that manually before we use the filesystem mocker.

See #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDGrimes JDGrimes

Labels
bug
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@JDGrimes