-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flags to control output structure & another flag for flat dumps #29
Conversation
…to directories by resource type instead of doing it by default
Hey I'll have to find some time to check it all out. And I think these edits will be included in the new version. |
@CollinShoop, I researched the solution a little. Shouldn't the Do you think it will not be difficult to implement it, and is it worth it? After all, when I specify specific resources, only they are saved. For example: ./kube-dump ns -n dev-app -r deployment,svc --output-by-type |
In any case, I accepted the changes and released the new version 1.1.0. Thank you so much for the work done. |
@WoozyMasta Thanks for the quick review & merge 🥇
I had the same observation when testing this, but my reasoning for keeping as-is is that it may be better to positively indicate that there are none of a particular resource with an empty file than to omit it which could be ambiguous (ie did the dump even check that resource type?). It's a bit annoying in the case of empty namespaces, though, but I'm not sure of a simple way to avoid that now.
I'll add this to my TODO 👍🏻 |
Actually, I see you've already updated the README.md and .env 💯 |
Hey @WoozyMasta 👋🏻 Very cool project, I was looking at making something just like this and figured I should contribute instead.
For my own use, having better control over the output structure would be ideal. I personally do not require resources to be broken up per file, and I also sometimes need all the detailed fields which were being removed via
jq
for debugging purposes (as opposed to backups, which I presume is the primary use case for this tool), so I've added a few new flags.