Skip to content

Commit

Permalink
Log if no execution endpoint is configured (sigp#3467)
Browse files Browse the repository at this point in the history
## Issue Addressed

Fixes an issue whereby syncing a post-merge network without an execution endpoint would silently stall. Sync swallows the errors from block verification so previously there was no indication in the logs for why the node couldn't sync.

## Proposed Changes

Add an error log to the merge-readiness notifier for the case where the merge has already completed but no execution endpoint is configured.
  • Loading branch information
michaelsproul authored and Woodpile37 committed Jan 6, 2024
1 parent 11938ac commit c8a1e66
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion beacon_node/client/src/notifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,21 @@ async fn merge_readiness_logging<T: BeaconChainTypes>(
payload.parent_hash() != ExecutionBlockHash::zero()
});

if merge_completed || !beacon_chain.is_time_to_prepare_for_bellatrix(current_slot) {
let has_execution_layer = beacon_chain.execution_layer.is_some();

if merge_completed && has_execution_layer
|| !beacon_chain.is_time_to_prepare_for_bellatrix(current_slot)
{
return;
}

if merge_completed && !has_execution_layer {
error!(
log,
"Execution endpoint required";
"info" => "you need an execution engine to validate blocks, see: \
https://lighthouse-book.sigmaprime.io/merge-migration.html"
);
return;
}

Expand Down

0 comments on commit c8a1e66

Please sign in to comment.