Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the storage of spiders in the database #5823

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Remove the storage of spiders in the database #5823

merged 12 commits into from
Feb 27, 2024

Conversation

Cyperghost
Copy link
Contributor

Closes #5295

@Cyperghost Cyperghost requested a review from dtdesign February 27, 2024 12:14
Copy link
Member

@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, please add @since 6.1 to all new classes.

@Cyperghost Cyperghost requested a review from dtdesign February 27, 2024 13:56
@Cyperghost Cyperghost merged commit 4c0cfbe into master Feb 27, 2024
10 checks passed
@Cyperghost Cyperghost deleted the spider-list branch February 27, 2024 14:45
@SoftCreatR
Copy link
Contributor

I did not check the code yet, but does this finally allow us to manually add new spiders to the list?

@dtdesign
Copy link
Member

Yes, that is what the SpiderCollecting event does: https://github.com/WoltLab/WCF/blob/198f05f08567c7500f0b0bd9cf9b34d61e0a3d8b/wcfsetup/install/files/lib/system/spider/event/SpiderCollecting.class.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bake spiderList into the code instead of storing it in the database
3 participants