Appearance changes #190
Appearance changes #190
Conversation
DavidSM100
force-pushed
the
appearance-changes
branch
from
15cb3c7 to
9b4decb
Compare
WofWca
force-pushed
the
master
branch
2 times, most recently
from
c593db6 to
1c80472
Compare
| background-color: var(--btn-bg-color); | ||
| } | ||
|
|
||
| button:hover:enabled { |
There was a problem hiding this comment.
This should also activate on :focus
| vertical-align: middle; | ||
| } | ||
|
|
||
| button:hover:enabled { |
There was a problem hiding this comment.
This should also activate on :focus
| <style> | ||
| @media (prefers-color-scheme: dark) { | ||
| :root { | ||
| --btn-bg-color: #333; | ||
| --btn-hover-bg-color: #555; | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: light) { | ||
| :root { | ||
| --btn-bg-color: #ddd; | ||
| --btn-hover-bg-color: #bbb; | ||
| } | ||
| } | ||
|
|
||
| button { | ||
| border: none; | ||
| border-radius: 5px; | ||
| background-color: var(--btn-bg-color); | ||
| } |
There was a problem hiding this comment.
Since these styles are duplicated among different files, it'd be worth adding a comment about it, so that people don't forget to update the other place as well.
There was a problem hiding this comment.
Yes, you are right.
Good question, the icons are from the feather icons project, I will check if we need to add copyright or something. |
Co-authored-by: WofWca <[email protected]>
|
No need to add copyright notice for the icons. |
|
How do you know? |
|
It doesn't say anything about it anywhere in that project but I'm not expert in these kind of stuff so you better check it out: |
No description provided.