Add tests for collection views #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +86,7 @@ final class EmptyStateView: UIView { | |||
| } | |||
|
|
|||
| override public func didMoveToSuperview() { | |||
| super.didMoveToSuperview() | |||
| import Foundation | ||
| import WLEmptyState | ||
|
|
||
| class DefaultCollectionViewController: UICollectionViewController, WLEmptyStateDataSource { |
There was a problem hiding this comment.
Not a big deal. Though, can we mark these classes and the ones for TableView as final?
Abel7x
approved these changes
Jul 1, 2019
| } | ||
| return items | ||
| private func getNumberOfSections() -> Int { | ||
| return (self as? UITableView).flatMap { $0.dataSource?.numberOfSections?(in: $0) } ?? |
leonardo-garcia
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Any background context you want to provide?
This PR adds the missing unit tests for empty states on collection views.
Where should the reviewer start?
Example/Tests/DataSourceTests.swiftHow should this be manually tested?
What are the relevant tickets?
#26