Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement versioned themes #521

Merged
merged 17 commits into from
Oct 22, 2024
Merged

Implement versioned themes #521

merged 17 commits into from
Oct 22, 2024

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Oct 21, 2024

This PR implements MEP #514 and marks the changes from #512 as experimental, as discussed in #466 (comment).

Tasks

  • Implement the syntax @⟨version⟩ for themes, according to MEP #514.
  • Add the Lua option experimental that causes theme witiko/markdown/defaults@experimental to be loaded.
  • Only apply the changes from #512 in the LaTeX theme witiko/markdown/defaults if the option experimental has been enabled or if any LaTeX test phase has been enabled.
  • Raise errors when deprecated features are used after the option experimental has been enabled.
  • Update CHANGES.md.

Manual tests

  • Try loading the default themes with/without the version experimental and check that the correct package is used to render tight and fancy lists.
  • Try loading the markdown package with/without the option experimental enabled and check that the correct package is used to render tight and fancy lists.
  • Try loading the markdown package with/without a LaTeX test phase enabled and check that the correct package is used to render tight and fancy lists.
  • Try loading the markdown package with the packages enumitem/paralist preloaded and check that tight and fancy lists are correctly rendered.
  • Test that (not) using the syntax @⟨version⟩ correctly sets the macro \markdownThemeVersion, even in nested themes.
  • Test that repeatedly loading the same plain TeX/LaTeX/ConTeXt themes with the same/different versions produces the correct logs/error.

Closes #466 and #514.

@Witiko Witiko added plaintex Related to the plain TeX interface and implementation latex Related to the LaTeX interface and implementation defaults Related to default option values and renderer prototypes themes Related to Markdown themes labels Oct 21, 2024
@Witiko Witiko added this to the 3.8.0 milestone Oct 21, 2024
@Witiko Witiko self-assigned this Oct 21, 2024
@Witiko Witiko changed the title Implement versioned theme Implement versioned themes Oct 21, 2024
@Witiko Witiko added the lua Related to the Lua interface and implementation label Oct 21, 2024
@Witiko Witiko force-pushed the feat/versioned-themes branch from 7613c10 to 45f980e Compare October 21, 2024 16:01
@Witiko Witiko merged commit c8e9654 into main Oct 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defaults Related to default option values and renderer prototypes latex Related to the LaTeX interface and implementation lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation themes Related to Markdown themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review compatibility of LaTeX dependencies with PDF tagging
1 participant