Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent endless loop when setting deprecated jekyllDataString (renderer) prototype #500

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Sep 17, 2024

Since #451 from Markdown 3.7.0, the jekyllDataString (renderer) prototype has been deprecated in favor of the jekyllDataTypographicString alias. While the jekyllDataString (renderer) prototype is still produced by globbing, we no longer allow users to set it directly by an error in #451. Therefore, setting jekyllDataString (renderer) prototype or any glob that includes jekyllDataString will produce an endless loop, since any (renderer) prototype that cannot be set is considered a glob and will be expanded ad infinitum.

Tasks

  • Allow renderer (prototype) jekyllDataString to be set.
  • Do not provide default jekyllDataString renderer (prototype).
  • Test that jekyllDataString renderer (prototype) can be set.
  • Update CHANGES.md

@Witiko Witiko added bug plaintex Related to the plain TeX interface and implementation conversion output Related to the output format of the Markdown-to-TeX conversion yaml Related to the tinyyaml library. expl3 Related to the high-level programming language expl3 labels Sep 17, 2024
@Witiko Witiko added this to the 3.7.1 milestone Sep 17, 2024
@Witiko Witiko self-assigned this Sep 17, 2024
@Witiko Witiko marked this pull request as ready for review September 17, 2024 20:50
@Witiko Witiko merged commit f8fba74 into main Sep 17, 2024
12 checks passed
@Witiko Witiko deleted the fix/jekyllDataString branch September 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug conversion output Related to the output format of the Markdown-to-TeX conversion expl3 Related to the high-level programming language expl3 plaintex Related to the plain TeX interface and implementation yaml Related to the tinyyaml library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant