Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for attributes on tables #313

Merged
merged 7 commits into from
Jul 22, 2023
Merged

Add support for attributes on tables #313

merged 7 commits into from
Jul 22, 2023

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Jul 18, 2023 •
edited
Loading

Closes #310.

Tasks

  • Add tableAttributes Lua option.
  • Pass tableAttributes option to extensions.pipe_tables.
  • Add renderers tableAttributeContextBegin and tableAttributeContextEnd to extensions.pipe_tables writer.
  • Define and document renderers and renderer prototypes tableAttributeContextBegin and tableAttributeContextEnd.
  • React to options tableAttributes and tableCaptions by expecting attributes at the end of table captions in extensions.pipe_tables reader.
  • Add unit tests.
  • Update CHANGES.md

@Witiko Witiko added lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation latex Related to the LaTeX interface and implementation defaults Related to default option values and renderer prototypes labels Jul 18, 2023
@Witiko Witiko added this to the 3.0.0-alpha.2 milestone Jul 18, 2023
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from 896bb50 to 71f32d0 Compare July 20, 2023 13:37
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from 71f32d0 to af244e7 Compare July 20, 2023 13:52
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from 315ee44 to cd33b9c Compare July 20, 2023 13:56
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from d49647e to 7005e4a Compare July 20, 2023 19:04
@Witiko Witiko force-pushed the feat/attributes-on-tables branch 2 times, most recently from 11be7ec to 5395266 Compare July 21, 2023 17:18
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from ab56a51 to 9dd3599 Compare July 21, 2023 17:20
@Witiko Witiko force-pushed the feat/attributes-on-tables branch from faec3f7 to 157b1a1 Compare July 21, 2023 22:01
@Witiko Witiko marked this pull request as ready for review July 21, 2023 22:40
@Witiko Witiko added the automerge This pull request will be automatically merged after continuous integration has succeeded label Jul 21, 2023
@github-actions github-actions bot merged commit 52a4452 into main Jul 22, 2023
@Witiko Witiko deleted the feat/attributes-on-tables branch July 22, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded defaults Related to default option values and renderer prototypes latex Related to the LaTeX interface and implementation lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation
Projects
None yet
Milestone
3.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

Add support for attributes on tables
1 participant
@Witiko