Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debugExtensions and debugExtensionsFileName Lua options for debugging user-defined syntax extensions #192

Merged
merged 13 commits into from
Oct 3, 2022
Merged

Add debugExtensions and debugExtensionsFileName Lua options for debugging user-defined syntax extensions #192

merged 13 commits into from
Oct 3, 2022

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Oct 3, 2022 •
edited
Loading

Closes #191.

Tasks

  • Define debugExtensions Lua option of type boolean that serializes walkable_grammar to a JSON document.
  • Define debugExtensionsFileName Lua option of type path.
  • Add names to built-in and user-defined syntax extensions and track these names in walkable_grammar via the reader->insert_pattern() function.
  • Implement the debugExtensions and debugExtensionsFileName options.
    • Add pattern_name optional argument to reader->insert_pattern() and increment api_version.
  • Add an example of the debugExtensions option to the user manual.
  • Update CHANGES.md.

@Witiko Witiko added bug lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown quality of life Related to quality-of-life improvements to the interface markdown3 labels Oct 3, 2022
@Witiko Witiko added this to the 2.17.1 milestone Oct 3, 2022
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch from 470b08b to a59ec3c Compare October 3, 2022 09:16
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch from 6cf2a30 to e960bdb Compare October 3, 2022 09:49
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch 7 times, most recently from b8e8123 to c8398a5 Compare October 3, 2022 11:38
@Witiko
Add names to built-in and user-defined syntax extensions
a66e0b1 
We track these names in `walkable_grammar` via the
`reader->insert_pattern()` and `...->update_rule()` functions.
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch from 88e1dc7 to a66e0b1 Compare October 3, 2022 11:56
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch from ce4afab to 658fbbe Compare October 3, 2022 12:04
@Witiko Witiko changed the title Add debugExtensions and debugExtensionsFileName for debugging user-defined syntax extensions Add debugExtensions and debugExtensionsFileName Lua options for debugging user-defined syntax extensions Oct 3, 2022
@Witiko Witiko marked this pull request as ready for review October 3, 2022 12:33
@Witiko Witiko added the automerge This pull request will be automatically merged after continuous integration has succeeded label Oct 3, 2022
@Witiko Witiko force-pushed the fix/add-debug-extensions-option branch from d1f277a to 52d2423 Compare October 3, 2022 12:35
@github-actions github-actions bot merged commit 98577dd into main Oct 3, 2022
@Witiko Witiko deleted the fix/add-debug-extensions-option branch October 3, 2022 13:14
Witiko pushed a commit that referenced this pull request Oct 3, 2022
@github-actions @Witiko
Merge pull request #192 from Witiko/fix/add-debug-extensions-option
8ca83f5 
Add `debugExtensions` and `debugExtensionsFileName` Lua options for debugging user-defined syntax extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded bug lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation quality of life Related to quality-of-life improvements to the interface syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Milestone
2.17.1
Development

Successfully merging this pull request may close these issues.

Add support for debugging user-defined syntax extensions
1 participant
@Witiko