Remove redundant parameters to fancy list item renderers and fix tight fancy lists #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witiko
added
bug
lua
Witiko
force-pushed
the
fix/remove-redundant-fancy-list-parameters
branch
10 times, most recently
from
c6f45b4 to
aa7d5ae
Compare
Witiko
force-pushed
the
fix/remove-redundant-fancy-list-parameters
branch
from
aa7d5ae to
4fcf3ad
Compare
Witiko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #168, we added support for fancy lists at the cost of redundancy in the parameters to fancy list item renderers. Furthermore, we also incorrectly implemented tight fancy lists, resulting in items other than the first not being recognized. This PR fixes both issues.