Fixed command-line parsing for arguments in GUI application, Added ability to specify execution working directory #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphillips-lab
changed the title
|
I also created another argument in both the GM utility and GUI that should allow the user to specify the working directory of the program being executed via the StartInfo options. I am proposing to add this specifically for the use case of dumping a DLL via a proxy DLL Loader such as SharpDllLoader. I found this to be useful when dealing with DLLs that reference relative paths. It is an optional argument, so if the user does not specify a path, then the default will be according to the MS documentation: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.workingdirectory?view=net-7.0#system-diagnostics-processstartinfo-workingdirectory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really simple fix, but I ran into an issue that caused the GM utility to crash when trying to use it to execute programs from within the GUI when the program arguments start with a dash ("-"). It is because of an outstanding issue attached to the CommandLine dependency. #690
It doesn't seem like this is going to be merged over there any time soon, so the work-around is to use the equals ("=") operator so the dependency can parse it properly.