fix: remove unused isNew prop in admin edit

With-the-Ranks · Nov 13, 2024 · 3902e31 · 3902e31
1 parent 9a56c63
commit 3902e31
Showing 1 changed file with 4 additions and 20 deletions.
diff --git a/src/containers/AdminCampaignEdit/index.jsx b/src/containers/AdminCampaignEdit/index.jsx
@@ -17,7 +17,6 @@ import { CampaignBuilderMode } from "@spoke/spoke-codegen";
 import isEqual from "lodash/isEqual";
 import pick from "lodash/pick";
 import PropTypes from "prop-types";
-import queryString from "query-string";
 import React from "react";
 import { Helmet } from "react-helmet";
 import { compose } from "recompose";
@@ -61,9 +60,7 @@ import CampaignVariablesForm from "./sections/CampaignVariablesForm";
 class AdminCampaignEdit extends React.Component {
   constructor(props) {
     super(props);
-    const isNew = queryString.parse(props.location.search).new;
     this.state = {
-      expandedSection: isNew ? 0 : null,
       campaignFormValues: { ...props.campaignData.campaign },
       startingCampaign: false,
       isWorking: false,
@@ -144,10 +141,6 @@ class AdminCampaignEdit extends React.Component {
     return sectionState;
   }
 
-  isNew = () => {
-    return Boolean(queryString.parse(this.props.location.search).new);
-  };
-
   handleDeleteJob = async (jobId) => {
     if (
       // eslint-disable-next-line no-alert,no-restricted-globals
@@ -175,8 +168,7 @@ class AdminCampaignEdit extends React.Component {
     await this.handleSave();
     this.setState({
       expandedSection:
-        this.state.expandedSection >= this.sections().length - 1 ||
-        !this.isNew()
+        this.state.expandedSection >= this.sections().length - 1
           ? null
           : this.state.expandedSection + 1
     }); // currently throws an unmounted component error in the console
@@ -654,14 +646,8 @@ class AdminCampaignEdit extends React.Component {
   renderCampaignFormSection = (section, forceDisable) => {
     const { isWorking } = this.state;
     const shouldDisable =
-      isWorking ||
-      forceDisable ||
-      (!this.isNew() && this.checkSectionSaved(section));
-    const saveLabel = isWorking
-      ? "Working..."
-      : this.isNew()
-      ? "Save and goto next section"
-      : "Save";
+      isWorking || forceDisable || this.checkSectionSaved(section);
+    const saveLabel = isWorking ? "Working..." : "Save";
     const ContentComponent = section.content;
     const formValues = this.getSectionState(section);
     return (
@@ -859,8 +845,7 @@ class AdminCampaignEdit extends React.Component {
     const { expandedSection, requestError } = this.state;
     const { isAdmin, match } = this.props;
     const { campaignId } = match.params;
-    const isNew = this.isNew();
-    const saveLabel = isNew ? "Save and goto next section" : "Save";
+    const saveLabel = "Save";
 
     const errorActions = [
       <Button key="ok" color="primary" onClick={this.handleCloseError}>
@@ -885,7 +870,6 @@ class AdminCampaignEdit extends React.Component {
                 organizationId={match.params.organizationId}
                 campaignId={campaignId}
                 active={expandedSection === sectionIndex}
-                isNew={isNew}
                 saveLabel={saveLabel}
                 onError={this.handleSectionError}
                 onExpandChange={this.handleExpandChange(sectionIndex)}