Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux prebuilt binaries for armv7 and arm64 and other improvements #758

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Feb 1, 2022

This PR adds multiple new features and improvements.

  • Added armv7 prebuilt binaries for Alpine
  • Added both armv7 and arm64 prebuilt binaries for Linux (very useful for Raspbian users)
  • All the jobs that runs on Qemu containers now uses checkout action which supports correct trigger ref
  • Added publish job completion requirement to all jobs

As always, all these changes were tested on multiple releases, for weeks at better-sqlite3-multiple-ciphers.

@tkurki
Copy link

tkurki commented Mar 11, 2022

Could maintainers comment here? Would be nice to know what to expect - any hope of this getting merged or is this going to be stalled?

@mceachen
Copy link
Member

sorry for the latency, github didn't send me a notification. LGTM, thanks for the work, @m4heshd, and for the ping, @tkurki

@JoshuaWise are you ok with merging this?

@EnriqCG
Copy link

EnriqCG commented Mar 26, 2022

Hey there! There have been no updates in the past 15 days so posting here to bump it.

@JoshuaWise JoshuaWise merged commit 5e07181 into WiseLibs:master Apr 7, 2022
@JoshuaWise
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants