Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compilation.md with automated script. #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccorcos
Copy link

@ccorcos ccorcos commented Feb 27, 2024

No description provided.

@ccorcos ccorcos requested review from JoshuaWise and a team as code owners February 27, 2024 16:20
mkdir -p sqlite-amalgamation
cd sqlite-amalgamation

curl -O https://sqlite.com/2024/sqlite-amalgamation-3450100.zip
Copy link
Member

@mceachen mceachen Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write this PR!

Unfortunately, I suspect people will blindly copy and paste this in the future and not realize they're pulling in an out of date amalgamation (this library is popular, and people open spurious bugs continuously. I suspect this will be a new source.)

If you want to be fancy, you can do something like this, which would be evergreen.

  1. do the npm install better-sqlite3 first.
  2. then mkdir -p sqlite-amalgamation && cd sqlite-amalgamation
  3. then something like this:
source <(egrep "^(YEAR|VERSION)=" ../node_modules/better-sqlite3/deps/download.sh)
curl https://sqlite.org/$YEAR/sqlite-amalgamation-$VERSION.tar.gz | tar -xz --strip 1

To fetch and extract into your new dir.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants