Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nuget to package reference for WireMock.Net.Console.Net472.Cla… #804

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

mattisking
Copy link
Contributor

…ssic, move the new FireAndForget into the main mapping, out of individual webhook mappings making it all or nothing, update tests, change Middleware to await or not the firing of all webhooks. Update models as needed.

…ssic, move the new FireAndForget into the main mapping, out of individual webhook mappings making it all or nothing, update tests, change Middleware to await or not the firing of all webhooks. Update models as needed.
@StefH
Copy link
Collaborator

StefH commented Sep 7, 2022

@mattisking
Thank you. I'll merge your PR into my branch, check some small things, and then it's ok to merge to master.

@StefH StefH merged commit 7e328a0 into WireMock-Net:stef-webhooks Sep 7, 2022
StefH added a commit that referenced this pull request Sep 12, 2022
* UseFireAndForget

* ...

* delay

* async

* updated code accorsing to proposal

* Change nuget to package reference for WireMock.Net.Console.Net472.Classic, move the new FireAndForget into the main mapping, out of individual webhook mappings making it all or nothing, update tests, change Middleware to await or not the firing of all webhooks. Update models as needed. (#804)

Co-authored-by: Matt Philmon <[email protected]>

* small update

* Tweak middleware and fix bug in example (#806)

Co-authored-by: Matt Philmon <[email protected]>

* .ConfigureAwait(false)

Co-authored-by: mattisking <[email protected]>
Co-authored-by: Matt Philmon <[email protected]>
@StefH StefH added the feature label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants