Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with concurrent logging #63

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Fix issue with concurrent logging #63

merged 2 commits into from
Nov 18, 2017

Conversation

volodymyr-fed
Copy link
Contributor

Fixed issue with concurrent logging:

  • added ConcurrentObservableCollection which is thread safe
  • added test for checking logging with parallel requests
  • added GlobalExceptionMiddleware that handles all exceptions that can happen in next middlewares
  • changed response body from exception message to serialized exception when exception is thrown(it`s better to have whole exception fields than only exception message)

@StefH StefH merged commit a15e674 into WireMock-Net:master Nov 18, 2017
@StefH
Copy link
Collaborator

StefH commented Nov 18, 2017

Do you need a new NuGet for this PR?

@volodymyr-fed
Copy link
Contributor Author

Yes, it will be great, thanks

@volodymyr-fed volodymyr-fed deleted the feature/ConcurrentLogEntities branch November 19, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefH StefH StefH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volodymyr-fed @StefH