-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding netcoreapp3.1 as a target framework #509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 76.01% 76.00% -0.01%
==========================================
Files 135 135
Lines 5249 5248 -1
Branches 517 517
==========================================
- Hits 3990 3989 -1
Misses 1105 1105
Partials 154 154
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look
CI build fails ; can you take a look? |
…USE_ASPNETCORE where possible
@StefH It think CI is good with the exception of code coverage, the problem is I'm not sure how I reduced overall coverage. Would you mind just letting me know the best way to address it? I would be happy to add a test if necessary. If it is possible to get a MyGet build, I would happily run the Snyk scan against it! |
Thank you! Yeah I saw the CI fail yesterday, I assume it was something to do with the pre-feedback code using the wrong preprocessors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@APIWT version 1.3.1 is released to nuget |
Attempting to remove a dependency on
Microsoft.AspNetCore
packages for projects targetting netcoreapp3.0 or greater#507