Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Proxy when using MultipartForm with byte[] #473

Merged
merged 4 commits into from
May 23, 2020
Merged

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented May 23, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #473 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   75.69%   75.74%   +0.04%     
==========================================
  Files         131      132       +1     
  Lines        5044     5054      +10     
  Branches      498      499       +1     
==========================================
+ Hits         3818     3828      +10     
  Misses       1078     1078              
  Partials      148      148              
Impacted Files Coverage Δ
src/WireMock.Net/Owin/Mappers/OwinRequestMapper.cs 95.91% <ø> (ø)
src/WireMock.Net/Util/BodyParser.cs 95.28% <ø> (ø)
src/WireMock.Net/Http/ByteArrayContentHelper.cs 100.00% <100.00%> (ø)
src/WireMock.Net/Http/HttpRequestMessageHelper.cs 81.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e3f38...e2fe501. Read the comment docs.

/// <param name="content">The byte[] content (cannot be null)</param>
/// <param name="contentType">The ContentType (can be null)</param>
/// <returns>ByteArrayContent</returns>
internal static ByteArrayContent Create([NotNull] byte[] content, [CanBeNull] MediaTypeHeaderValue contentType)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use nullable reference types feature in the modern C#, where it is available, it rocks. Just a note.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I started using the new features for some small new projects on GitHub.
However, I did not yet check this project. Will take some time to fix all warnings I think.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will. And sometimes it reveals some problems or requires a chain of modifications, but, ultimately, you have a good feeling that the codebase became more reliable and organized, I like it :)

@StefH StefH merged commit 1b1ddea into master May 23, 2020
@StefH StefH deleted the multipart_form branch May 23, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants