-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Proxy when using MultipartForm with byte[] #473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 75.69% 75.74% +0.04%
==========================================
Files 131 132 +1
Lines 5044 5054 +10
Branches 498 499 +1
==========================================
+ Hits 3818 3828 +10
Misses 1078 1078
Partials 148 148
Continue to review full report at Codecov.
|
/// <param name="content">The byte[] content (cannot be null)</param> | ||
/// <param name="contentType">The ContentType (can be null)</param> | ||
/// <returns>ByteArrayContent</returns> | ||
internal static ByteArrayContent Create([NotNull] byte[] content, [CanBeNull] MediaTypeHeaderValue contentType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use nullable reference types feature in the modern C#, where it is available, it rocks. Just a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I started using the new features for some small new projects on GitHub.
However, I did not yet check this project. Will take some time to fix all warnings I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will. And sometimes it reveals some problems or requires a chain of modifications, but, ultimately, you have a good feeling that the codebase became more reliable and organized, I like it :)
No description provided.