-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blacklist for Request Cookies. #319
Add blacklist for Request Cookies. #319
Conversation
Refactor code. Fix tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tests fail, please fix these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 2 tests fail, please fix these
- and see other comment
A question: currently the blacklisted headers and cookies are just a string array. Wouldn't it be better if an array/collection of IStringMatcher would be allowed. When using a IStringMatcher, more complex matching like Wildcard or Regex are possible. What are your thoughts? |
Not sure if it brings that much value. Headers and Cookies are pretty unique and well-known so defining exact names collection is ok. Most likely you want to filter all that out. |
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 79.94% 79.93% -0.02%
==========================================
Files 110 111 +1
Lines 4379 4420 +41
==========================================
+ Hits 3501 3533 +32
- Misses 878 887 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
A new NuGet will be created in some time... |
Refactor code. Fix tests.