Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BodyAsJson transform bug in ResponseMessageTransformer #261

Merged
merged 1 commit into from Mar 30, 2019
Merged

Fix BodyAsJson transform bug in ResponseMessageTransformer #261

merged 1 commit into from Mar 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2019

Fix ResponseMessageTransformer to not replace BodyAsJson in an original message with transformed results

…al message

Fix ResponseMessageTransformer to not replace BodyAsJson in an original message with transformed results
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files         103      103           
  Lines        5147     5147           
=======================================
  Hits         4621     4621           
  Misses        526      526
Impacted Files Coverage Δ
...ock.Net/Transformers/ResponseMessageTransformer.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e5992...8310ea4. Read the comment docs.

@ghost
Copy link
Author

ghost commented Mar 29, 2019

Want to mention that it means that if a consumer uses BadyAsJson with any handlebars functionality (transformer) it will work properly the first time, but then it will return the same response body for all next requests instead of generating them with transformers.

@StefH
Copy link
Collaborator

StefH commented Mar 29, 2019

I think I understand your issue. However, can you maybe create a unit-test to test this behaviour.

@StefH StefH merged commit ceb6596 into WireMock-Net:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant