Fix for issue #118 #121
Fix for issue #118 #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 66.56% 66.99% +0.43%
==========================================
Files 79 79
Lines 2862 2866 +4
Branches 389 390 +1
==========================================
+ Hits 1905 1920 +15
+ Misses 742 728 -14
- Partials 215 218 +3
Continue to review full report at Codecov.
|
|
@StefH should I include any tests for this or this is fine? |
|
If you can create a simple small test, to make sure the code coverage increases, that would be nice. |
|
@StefH I have added a test to cover the code. It required to fix one test too. |
|
|
||
| string responseBodyFilePath = Path.Combine(GetCurrentFolder(), "ResponseBodyFiles", "responsebody.json"); | ||
|
|
||
| dynamic jsonObj = Newtonsoft.Json.JsonConvert.DeserializeObject(json); |
There was a problem hiding this comment.
Newtonsoft.Json is not needed here. Please import this namespace in this file.
There was a problem hiding this comment.
I have moved this to using block and updated the commit. @StefH
|
@StefH updated the pull request. |
|
@StefH please let me know if I can merge pull request? |
|
I will merge this PR in the weekend. And create new NuGet. |
|
@StefH please let me know if I can merge pull request? |
Including the code to accept BodyAsFile in the response when the mappings are placed in the file.