-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonPartialMatcher - match guid and string #971
Labels
Comments
Looks ok to me. However I think that this same logic needs to be applied to line 66 if a Regex is used: if (Regex && value.Type == JTokenType.String && input != null) |
timurnes
added a commit
to timurnes/WireMock.Net
that referenced
this issue
Jul 19, 2023
timurnes
added a commit
to timurnes/WireMock.Net
that referenced
this issue
Jul 19, 2023
StefH
pushed a commit
that referenced
this issue
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a WireMock user I'd like to setup JsonPartialMatcher using anonymous object with some Guid fields.
As of now I have to cast Guid fields to string because this condition in AbstractJsonPartialMatcher rejects match - value type is JTokenType.Guid and input type is JTokenType.String.
Generally, guid in json is a string so I think this feature can simplify user code a bit and won't be a breaking change
Possible solution is to add a check before the condition I've specified above
Unit test in JsonPartialMatcherTests:
The text was updated successfully, but these errors were encountered: