-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: Params does not work, when there are multiple values for a key #106
Comments
StefH
changed the title
Params does not work, when there are multiple values for a key
Issue: Params does not work, when there are multiple values for a key
Mar 10, 2018
Thanks for this report. |
Will be fixed soon, please watch updates here + NuGet. |
I have a fix for the same. I will create a pull request.
…On Sat, Mar 10, 2018, 8:19 PM Stef Heyenrath ***@***.***> wrote:
Will be fixed soon, please watch updates here + NuGet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#106 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AExkn3SWkC7X4k08R_eXbrv-7lAUoB7Rks5tc-f7gaJpZM4Sj-oZ>
.
|
Already fixed, no need for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For a request in the Param's, if we have multiple values for a key, we are not able to match the score for that request and return 410 saying could not find the mapping.
In a request for a query string parameter, we can have only one value. But in the structure, we are allowing an array of values that can be passed. That means for that key, it can be anything among the passed values.
example
here in params, we have the key "searched" and values being "test" and "test2". Now my request can be like
http://localhost:9092/xyz?searched=test
http://localhost:9092/xyz?searched=test2
We can have either of them. But we cannot have like http://localhost:9092/xyz?searched=test1,test2
In this case, in the RequestMessageParamMatcher.cs file, we are deciding the score based on the count of values. Ideally, this should have been done if the list contains the requests param value.
The text was updated successfully, but these errors were encountered: