[gearswap] Update export.lua #2346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z16
reviewed
Apr 6, 2024
addons/GearSwap/export.lua
Outdated
| function export_set(options) | ||
| local item_list = T{} | ||
| local targinv,all_items,minify,all_sets,use_job_in_filename,use_subjob_in_filename,overwrite_existing,named_file | ||
| local targinv,all_items,wearable,all_sets,noaugments,onlyaugmented,minify,clipboard | ||
| local use_job_in_filename,use_subjob_in_filename,overwrite_existing,named_file |
There was a problem hiding this comment.
I know this is not your doing, but I would put these all on separate lines and initialize them with default values (false for most of them).
addons/GearSwap/export.lua
Outdated
| function export_set(options) | ||
| local item_list = T{} | ||
| local targinv,all_items,minify,all_sets,use_job_in_filename,use_subjob_in_filename,overwrite_existing,named_file | ||
| local targinv,all_items,wearable,all_sets,noaugments,onlyaugmented,minify,clipboard | ||
| local use_job_in_filename,use_subjob_in_filename,overwrite_existing,named_file | ||
| if #options > 0 then | ||
| for _,v in ipairs(options) do | ||
| if S{'inventory','inv','i'}:contains(v:lower()) then |
There was a problem hiding this comment.
v is lowercased all the time. Define it once at the top and use that:
local option = v:lower()
|
Still working on this, hopefully I can submit the new code soonTM. |
Removed some code duplication and reordered some other code. Added a new `copy`/`clipboard` flag, which makes GS export the table to clipboard instead of to a file. INPUT NEEDED: I also added two new flags, `noaugments` and `onlyaugmented` which respectively do: - `noaugments`/`noaugs` exports the set without recording the augments on each item (useful if you mostly have single-path items so you don't get a spam of `Path: A` and such; or if you already have augmented items saved) - `onlyaugmented`/`onlyaugs` *only* exports items that have augments and ignores entirely non-augmented items (useful if you need to make variables for your augmented gear, or in combination with the `wearable` flag to export all augmented items that your current job can equip, to make a new gearswap file, etc) The issue I have is that I would like gearswap to print out a notice when provided one of these flags, but I can't come up with good ones myself 😄 input appreciated
Removed stray `log()` Tweaked argument parsing. Finalized displayed message.
Fixed markdown Added the newer options for the `export` command.
lili-ffxi
force-pushed
the
lili-gs-export-update
branch
from
830737c to
a4d05d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some code duplication and reordered some other code.
Added a new
copy/clipboardflag, which makes GS export the table to clipboard instead of to a file.INPUT NEEDED:
I also added two new flags,
noaugmentsandonlyaugmentedwhich respectively do:noaugments/noaugsexports the set without recording the augments on each item. Useful if you mostly have single-path items so you don't get a spam ofaugments={'Path: A'}and such; or if you already have augmented items saved.onlyaugmented/onlyaugsonly exports items that have augments and ignores entirely non-augmented items. Useful if you need to make variables for your augmented gear, or in combination with thewearableflag to export all augmented items that your current job can equip, to make a new gearswap file, etc.The issue I have is that I would like gearswap to print out a notice when provided one of these flags, but I can't come up with good ones myself 😄 input appreciated