Add logs on host reconcile path #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the host is already insync and reconciled, if it was degraded before the unlock, the availability status was not being updated. This commit adds a check in the Reconcile method to ensure that the availability status it's updated if the host is already reconciled but not available. Test Plan: PASS: Build image and deploy a AIO-DX where the issue was seen. Verify that the 'degraded' status it's updated to 'available' after unlock. Signed-off-by: Enzo Candotti <[email protected]>
yjian118
requested changes
Nov 14, 2024
enzocandotti
force-pushed
the
master
branch
2 times, most recently
from
2bb2f82 to
f85b1bf
Compare
yjian118
requested changes
Nov 14, 2024
|
|
@yjian118 slices was introduced in golang 1.21, the builder uses golang 1.22.2. I think we need to bump golang version in go.mod |
|
@wasnio yes, we need to bump up golang version in go.mod as minum requirement. And also re-visit our internal repo to find out the golang requirement in the build enviorment |
This commits aims to add more logs in the host reconcile path since it was seen situations in which the reconciler is blocked and current logs can not give the enough information to debug it. Signed-off-by: Enzo Candotti <[email protected]>
yjian118
approved these changes
Nov 15, 2024
yjian118
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits aims to add more logs in the host reconcile path since it was seen situations in which the reconciler is blocked and current logs can not give the enough information to debug it.