Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 38C3 #397

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add 38C3 #397

merged 1 commit into from
Dec 12, 2024

Conversation

schildbach
Copy link
Contributor

I left out c3nav for now.

Copy link

github-actions bot commented Dec 12, 2024

New: 38C3
File passed validation! \o/

@schildbach
Copy link
Contributor Author

I also removed refresh_interval because:

ERROR: Schedule 38C3 refresh_interval set below 1d while server never sends HTTP 304s

@schildbach
Copy link
Contributor Author

@Wilm0r ready for review.

@Wilm0r Wilm0r merged commit 8d001ae into Wilm0r:master Dec 12, 2024
1 check passed
@Wilm0r
Copy link
Owner

Wilm0r commented Dec 12, 2024

Hrmm.... Hadn't noticed the refresh interval thing before. I should fix that check, Giggity should be better at HTTP caching now (including ETags, which are more likely to work IIRC).

CCC does probably make last minute schedule changes somewhat regularly?

@schildbach
Copy link
Contributor Author

I got word that their server does indeed not handle the If-None-Match correctly atm. They want to look into it, but low prio atm.

Yes, schedule changes are frequent and often quite last-minute. Even entire locations (rooms) pop up last minute (-:

@mmuman
Copy link
Contributor

mmuman commented Dec 15, 2024

Oh cool, won't have to do it.
Yes there are usually many updates to the schedule…

@mmuman
Copy link
Contributor

mmuman commented Dec 15, 2024

It's sad the full schedule doesn't pull from an xml…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants