Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IETF121 #391

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add IETF121 #391

merged 3 commits into from
Oct 31, 2024

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Oct 18, 2024

It's in 2 weeks time, so not sure if that makes sense still, or whether I'd better keep the file somewhere else and disseminate through QR codes.

Copy link

github-actions bot commented Oct 18, 2024

New: IETF 121 Dublin
Error: Could not fetch IETF 121 Dublin https://datatracker.ietf.org/meeting/121/agenda.ics: HTTP 502 Bad Gateway

Error: Schedule IETF 121 Dublin refresh_interval set below 1d while server never sends HTTP 304s
Error: File validation failed! :-( Please correct the issues listed above.

@chrysn
Copy link
Contributor Author

chrysn commented Oct 18, 2024

The link I've fixing, also the version number (not sure I got it right, just followed the bot's directions).

The Refresh is odd: I specifically did check that the server does send a 304 on ETag match. (I didn't check for date based verifciation, but always found ETag to be more widespread and reliable anyway). I'm removing this, but we do have last minute changes, so I'd prefer to put it back in.

@Wilm0r
Copy link
Owner

Wilm0r commented Oct 18, 2024

Feel free to put the low refresh timeout back then, as long as the server is fast. :) In fact new versions of Giggity have a better HTTP fetcher that should send ETag headers, pretty sure I've released that a while ago already. So it's just the CI that is a little behind on facts.

2w is plenty notice when I'm (able to) pay(ing) attention to this queue BTW, np. Once submitted this bit will appear in ggt.gaa.st/menu.json ~instantly and Giggity loads that file about once a day or immediately if you swipe down to refresh in the main screen.

(And ahh, IETF in Dublin... I never had it that close back when I lived there and still had an RFC to publish.. :) )

@chrysn
Copy link
Contributor Author

chrysn commented Oct 31, 2024

Updated as you suggested -- the 2 weeks became 2 days because I missed this, but as you said, it's going out fast.

@Wilm0r
Copy link
Owner

Wilm0r commented Oct 31, 2024

D'oh, yep forgot it too. Merging.

@Wilm0r Wilm0r merged commit 83d63ac into Wilm0r:master Oct 31, 2024
1 check failed
@chrysn chrysn deleted the ietf121 branch October 31, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants