-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic hackmas castle 24 event #366
Conversation
New: Håck ma's Castle |
actions fails but doesn't provide an error. |
Weird that the comment is empty yes... :-/ but see https://github.com/Wilm0r/giggity/actions/runs/10164485309/job/28109952792?pr=366 for the actual error |
for me, this is ready to merge @Wilm0r |
i will do another pull request as soon c3nav is working. |
Thank you! BTW I see only 3 or 4 items in the schedule, shouldn't it be a lot more? |
The schedule will be organized with something in the direction of the barcamp with openki, a self organized learning platform. The most concrete events (with date and location) will be created maybe a day before the session will happen. Except the music schedule, which will be created earlier. |
Wow OK, that's very last minute :) Sorry, should've asked this earlier, and I'll pay attention to this PR today so that we can get it submitted, but ... the URL parameters, are they really really necessary? Only asking because if you want to delete them later, Giggity uses the full URL as the primary key so doing so would result in 2 hackmas menu entries with separate selections and all in all terrible UX. I've started working out a fix but it's not there yet... :( FWIW if I fetch the same URL without parameters I seem to get the exact same results at least, so I'm tempted to cut it off. |
The limit is necessary, because the default limit is something around 200-300. We won't change the parameters anymore tho. |
I really don't understand how these versionnumbers work... |
ok now i get it, it's current date + a number which must be growing |
Yeah, sorry about that, I should remove version numbers from these src files too some day. Much of Giggity is 15yo, not all design decisions are great. :) |
Hahaha, sounds like it should get a rewrite at some point. Thanks for supporting this app for so long! |
No description provided.