Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix VS2022 build errors in CI/CD #84

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Attempt to fix VS2022 build errors in CI/CD #84

merged 1 commit into from
Aug 25, 2022

Conversation

patridge
Copy link
Contributor

Bumped a single NuGet package. We went from build error to VSIX compatibility warnings, though.

@patridge patridge requested a review from CartBlanche August 25, 2022 18:03
CartBlanche
CartBlanche approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@CartBlanche CartBlanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patridge
Copy link
Contributor Author

Spun up a File>New Meadow project -> ✅ Success!

Right-click Deploy on project in Solution Explorer -> ✅ Success!
Build>Deploy Solution from menu -> 🚫 Fail (still a crash and relaunch of VS, but that's not new for me)

@CartBlanche CartBlanche merged commit 054ee69 into develop Aug 25, 2022
@CartBlanche CartBlanche deleted the fix-attempt-vs2022 branch August 25, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CartBlanche CartBlanche CartBlanche approved these changes

Assignees

@patridge patridge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patridge @CartBlanche