Check if the client still has connection before calling Send in a try/catch #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release V1.1.0.0
Release 1.5.0
…r. Changed async void Send<T> to async Task Send<T> and awaits on public calls to it.
added using to FileStream instances in both FileLogger and CloudLogge…
Chnage variables create in construtor to readonly to show intent. Check if _client still connected before creating message and attempting to send message.
ctacke
approved these changes
Mar 7, 2024
ctacke
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UDP logger needs to check the connection is still valid before calling Send and use try/catch to trap other exceptions to avoid the calling thread getting killed if the network has unexpectedly died or becomes inaccessible.
This change also marks some properties only initialised in the constructor as
readonlyto show the intent they should not be changed by other parts of the class.