Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded ctor device param #826

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Remove unneeded ctor device param #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Source/Meadow.Foundation.Peripherals/Displays.Tm1637/Driver/Tm1637.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,12 @@ internal enum DisplayCommand
/// <summary>
/// Initialize a TM1637
/// </summary>
/// <param name="device">The device connected to the display</param>
/// <param name="pinClock">The clock pin</param>
/// <param name="pinData">The data pin</param>
public Tm1637(IMeadowDevice device, IPin pinClock, IPin pinData)
public Tm1637(IPin pinClock, IPin pinData)
{
portClock = pinClock.CreateDigitalOutputPort();
portData = device.CreateBiDirectionalInterruptPort(pinData);
portData = pinData.CreateBiDirectionalPort();

_brightness = 7;
}
Expand Down
2 changes: 1 addition & 1 deletion Source/Meadow.Foundation.Peripherals/Displays.Tm1637/Samples/Tm1637_Sample/MeadowApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public override Task Initialize()
{
Resolver.Log.Info("Initialize...");

display = new Tm1637(Device, Device.Pins.D02, Device.Pins.D01);
display = new Tm1637(Device.Pins.D02, Device.Pins.D01);

display.Brightness = 7;
display.ScreenOn = true;
Expand Down
Loading