Add Lsm303agr Accel/Mag driver #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctacke
reviewed
Apr 12, 2023
| @@ -0,0 +1,12 @@ | |||
| namespace Meadow.Foundation.Sensors.Accelerometers | |||
| { | |||
| public partial class Lsm303agr | |||
There was a problem hiding this comment.
Any particular reason these registers are public?
There was a problem hiding this comment.
its a partial class, but the registers are not public
There was a problem hiding this comment.
yeah they're not public - partial public class but the fields are private
ctacke
reviewed
Apr 12, 2023
| /// </summary> | ||
| void Initialize() | ||
| { | ||
| i2cPeripheralAccel.WriteRegister(ACC_CTRL_REG1_A, 0x57); |
There was a problem hiding this comment.
minor nit, but these should probably be defined constants instead of magic numbers
There was a problem hiding this comment.
Yeah it's a compound value setting things up .... I could easily move it up. I often do this for init methods because they do end up with a crap ton of magic init values. Displays are terrible for it and it doesn't quite seem worth the hassle of creating 20ish defines.
jorgedevs
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.