Fix bounds checking in SetRegsiterBit and ClearRegisterBit - fixes #631

WildernessLabs · Apr 24, 2023 · 9650c96 · 9650c96
1 parent e87fad2
commit 9650c96
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Source/Meadow.Foundation.Peripherals/ICs.IOExpanders.Mcp23xxx/Driver/Mcp23xxx.cs b/Source/Meadow.Foundation.Peripherals/ICs.IOExpanders.Mcp23xxx/Driver/Mcp23xxx.cs
@@ -310,7 +310,7 @@ public IDigitalInputPort CreateDigitalInputPort(
 
         private void SetRegisterBit(byte register, int bit)
         {
-            if (bit >= 7 || bit < 0) { throw new ArgumentOutOfRangeException(); }
+            if (bit > 7 || bit < 0) { throw new ArgumentOutOfRangeException(); }
 
             var value = mcpDevice.ReadRegister(register);
             value |= (byte)(1 << bit);
@@ -319,7 +319,7 @@ private void SetRegisterBit(byte register, int bit)
 
         private void ClearRegisterBit(byte register, int bit)
         {
-            if (bit >= 7 || bit < 0) { throw new ArgumentOutOfRangeException(); }
+            if (bit > 7 || bit < 0) { throw new ArgumentOutOfRangeException(); }
             var value = mcpDevice.ReadRegister(register);
             value &= (byte)~(1 << bit);
             mcpDevice.WriteRegister(register, value);