Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

dex 1197 - rename server status to site status #428

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

Emily-Ke
Copy link
Contributor

@Emily-Ke Emily-Ke commented Jul 12, 2022

Pull request checklist:

  • Features and bugfixes should be PRed into the develop branch, not main
  • All text is internationalized
  • There are no linter errors
  • New features support all states (loading, error, etc) No new features

Which JIRA ticket(s) and/or GitHub issues does this PR address?

  • DEX-1197: Server Status page is hardcoded to Flukebook WBIA

Pull Request Overview

  • Changes the Server Status page to a Site Status page.

  • Fixes React errors in SuperText

    Each child in a list should have a unique "key" prop.
    
    react-dom.development.js:88 Warning: Received `false` for a non-boolean attribute `hide`.
    
    If you want to write it to the DOM, pass a string instead: hide="false" or hide={value.toString()}.
    
original renamed
original renamed

aria-label={`${color} legend box`}
aria-label={intl.formatMessage(
{ id: 'SERVER_COLOR_LEGEND_BOX' },
{ color },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color itself won't be internationalized, but because it is referencing a CSS color, that seemed acceptable.

@Emily-Ke Emily-Ke force-pushed the dex-1197-rename-server-status-to-site-status branch from 4304fb7 to 62d7b61 Compare July 12, 2022 16:51
@Emily-Ke Emily-Ke marked this pull request as ready for review July 12, 2022 16:52
@brmscheiner brmscheiner merged commit 40e3c86 into develop Jul 12, 2022
@brmscheiner brmscheiner deleted the dex-1197-rename-server-status-to-site-status branch July 12, 2022 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants