DEX-922 respond to code review feedback. Remove default maxHeight for…

… Card component and replaced with optional styles, which was then implemented for ImageCard and StatusCard. Remove maxHeight from Card in relationshipCard, remove unused paperStyles from DataDisplay.
WildMeOrg · Jul 21, 2022 · 1873372 · 1873372
1 parent a12ea15
commit 1873372
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/src/components/cards/Card.jsx b/src/components/cards/Card.jsx
@@ -7,9 +7,9 @@ export default function Card({
   title,
   titleId,
   htmlId = null,
-  maxHeight = 360,
   overflow = 'auto',
   overflowX = 'auto',
+  styles = {},
   renderActions,
   children,
 }) {
@@ -35,7 +35,7 @@ export default function Card({
           </Text>
           {renderActions}
         </div>
-        <div style={{ overflow, maxHeight, overflowX }}>
+        <div style={{ overflow, overflowX, ...styles }}>
           {children}
         </div>
       </Paper>

diff --git a/src/components/cards/RelationshipsCard.jsx b/src/components/cards/RelationshipsCard.jsx
@@ -341,7 +341,7 @@ export default function RelationshipsCard({
         </div>
       </DialogActions>
     </StandardDialog>,
-    <Card title={title} titleId={titleId} maxHeight={600}>
+    <Card title={title} titleId={titleId}>
       {/* // renderActions={
       //   <div>
       //     <IconButton

diff --git a/src/components/dataDisplays/DataDisplay.jsx b/src/components/dataDisplays/DataDisplay.jsx
@@ -61,7 +61,6 @@ export default function DataDisplay({
   sortExternally,
   searchParams,
   setSearchParams,
-  paperStyles = {},
   tableStyles = {},
   cellStyles = {},
   stickyHeader = true,
@@ -262,7 +261,6 @@ export default function DataDisplay({
         elevation={variant === 'secondary' ? 2 : undefined}
         style={{
           maxHeight,
-          ...paperStyles,
         }}
       >
         <Table

diff --git a/src/pages/fieldManagement/settings/defaultFieldComponents/SpeciesEditor.jsx b/src/pages/fieldManagement/settings/defaultFieldComponents/SpeciesEditor.jsx
@@ -167,7 +167,6 @@ export default function SpeciesEditor({
         )}
         <DataDisplay
           cellStyles={{ padding: '0 8px 0 12px' }}
-          paperStyles={{ maxHeight: 360 }}
           style={{ marginTop: 12 }}
           noTitleBar
           variant="secondary"

diff --git a/src/pages/match/ImageCard.jsx b/src/pages/match/ImageCard.jsx
@@ -40,7 +40,7 @@ export default function ImageCard({ titleId, annotation }) {
   );
 
   return (
-    <Card titleId={titleId} maxHeight="unset">
+    <Card titleId={titleId} styles={{ maxHeight: 'unset' }}>
       <AnnotatedPhotograph
         assetMetadata={{
           alt: 'Selected query annotation',

diff --git a/src/pages/sighting/statusCard/StatusCard.jsx b/src/pages/sighting/statusCard/StatusCard.jsx
@@ -170,7 +170,10 @@ export default function StatusCard({ sightingData }) {
   }
 
   return (
-    <Card titleId="IDENTIFICATION_PIPELINE_STATUS" maxHeight={900}>
+    <Card
+      titleId="IDENTIFICATION_PIPELINE_STATUS"
+      styles={{ maxHeight: 900 }}
+    >
       <Timeline>
         <TimelineStep
           Icon={ReportIcon}