Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER- Properly handle arrow up key in search suggestion navigation #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions source/components/GlobalNavigation/components/Search/Search.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,28 +78,27 @@ class Search extends React.Component {

event.stopPropagation();

switch (event.keyCode) {
// down arrow
case 40:
switch (event.key) {
case "Down":
case "ArrowDown":
if (selectedSuggestionIndex < suggestions.length - 1) {
this.setState({ selectedSuggestionIndex: selectedSuggestionIndex + 1 });
}

break;
// up arrow
case 30:
case "Up":
case "ArrowUp":
if (suggestions.length && selectedSuggestionIndex > -1) {
this.setState(({ selectedSuggestionIndex: selectedSuggestionIndex - 1 }));
}

break;
// ESC key
case 27:
case "Esc":
case "Escape":
this.onSearchClose();

break;
// ENTER key
case 13:
case "Enter":
if (selectedSuggestionIndex !== -1) {
onSearchSuggestionChosen(suggestions[selectedSuggestionIndex], suggestions, suggestionId);
this.input.current.blur();
Expand Down