refactor: review notes + webhooks PLATFORM-8899 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeller-wikia
force-pushed
the
PLATFORM-8899-CR
branch
from
230eb83 to
599ad32
Compare
mmeller-wikia
commented
Feb 5, 2024
identity/handler.go
Outdated
| // 204: emptyResponse | ||
| // 404: jsonError | ||
| // 500: jsonError | ||
| func (h *Handler) deleteMultifactorCredential(w http.ResponseWriter, r *http.Request, ps httprouter.Params) { |
There was a problem hiding this comment.
Note: It should be removed once we migrate to new API.
Note: New API will return 404 for not existing credential
mmeller-wikia
commented
Feb 5, 2024
| @@ -179,6 +180,7 @@ func (e *WebHook) ExecutePostVerificationHook(_ http.ResponseWriter, req *http.R | |||
| RequestURL: x.RequestURL(req).String(), | |||
| RequestCookies: cookies(req), | |||
| Identity: id, | |||
| HookType: "VerificationPostHook", | |||
There was a problem hiding this comment.
Note: Previously it was LoginPreHook
mmeller-wikia
commented
Feb 5, 2024
| @@ -204,6 +207,7 @@ func (e *WebHook) ExecutePostRecoveryHook(_ http.ResponseWriter, req *http.Reque | |||
| RequestURL: x.RequestURL(req).String(), | |||
| RequestCookies: cookies(req), | |||
| Identity: session.Identity, | |||
| HookType: "RecoveryPostHook", | |||
There was a problem hiding this comment.
Note: Previously it was PostRecoveryHook
mmeller-wikia
commented
Feb 5, 2024
adpaste
force-pushed
the
fandom_master_1_0_0
branch
2 times, most recently
from
a18ee93 to
af00b58
Compare
mmeller-wikia
commented
Feb 6, 2024
driver/registry_default_settings.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| func (m *RegistryDefault) PostSettingsPrePersistHooks(ctx context.Context, settingsType string) (b []settings.PostHookPrePersistExecutor) { | |||
| for _, v := range m.getHooks(settingsType, m.Config().SelfServiceFlowSettingsAfterHooks(ctx, settingsType)) { | |||
| for _, v := range m.getHooks(settingsType, filter(m.Config().SelfServiceFlowSettingsAfterHooks(ctx, settingsType), config.PrePersist)) { | |||
There was a problem hiding this comment.
TODO: check if all filter calls are in place
mmeller-wikia
commented
Feb 6, 2024
selfservice/hook/web_hook.go
Outdated
| @@ -484,7 +509,8 @@ func (e *WebHook) execute(ctx context.Context, data *templateContext) error { | |||
| if resp.StatusCode >= http.StatusBadRequest { | |||
| span.SetStatus(codes.Error, "HTTP status code >= 400") | |||
| if canInterrupt || parseResponse { | |||
| if err := parseWebhookResponse(resp, data.Identity); err != nil { | |||
| // TODO: double-check if we could use upstream `parseWebhookResponse` | |||
mmeller-wikia
commented
Feb 6, 2024
Comment on lines
+412
to
+419
| httpClient = e.deps.NamedHTTPClient( | ||
| ctx, | ||
| data.HookType+conf.sum, | ||
| httpx.ResilientClientWithMaxRetry(conf.retries), | ||
| httpx.ResilientClientWithConnectionTimeout(conf.timeout), | ||
| httpx.ResilientClientWithMinxRetryWait(conf.minWait), | ||
| httpx.ResilientClientWithMaxRetryWait(conf.maxWait), | ||
| ) |
There was a problem hiding this comment.
Maybe we could push this change to upstream
There was a problem hiding this comment.
I think we should add ACs to all such tickets
# Conflicts: # driver/registry_default_settings.go
adpaste
approved these changes
Feb 19, 2024
adpaste
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fandom_master_1_0_0 #97 +/- ##
====================================================
Coverage 76.78% 76.78%
====================================================
Files 330 330
Lines 22006 22006
====================================================
Hits 16897 16897
Misses 3813 3813
Partials 1296 1296 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #95 and #96