Initial stub at implementing updating credentials #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayful
commented
Oct 12, 2021
|
|
||
| type CredentialsBody struct { | ||
| Type CredentialsType `json:"type"` | ||
| Config sqlxx.JSONRawMessage `json:"config"` |
There was a problem hiding this comment.
This probably needs to be a different input type and has to be parsed and validated.
slayful
commented
Oct 12, 2021
| } | ||
|
|
||
| type CredentialsBody struct { | ||
| Type CredentialsType `json:"type"` |
There was a problem hiding this comment.
I'm not sure if I want to use this type, because it would kinda force us into accepting only hashed (more likely) or plain (less likely) passwords. I'd say upstream wants hashed but for our migration's purposes we want plain for the time being.
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments