PLATFORM-9035 Fix login/email change #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fandom_master_1_0_0 #104 +/- ##
======================================================
Coverage ? 76.77%
======================================================
Files ? 330
Lines ? 21975
Branches ? 0
======================================================
Hits ? 16872
Misses ? 3811
Partials ? 1292 ☔ View full report in Codecov by Sentry. |
adpaste
force-pushed
the
PLATFORM-9035_rename_fix
branch
from
31a1b67 to
59b1409
Compare
adpaste
force-pushed
the
PLATFORM-9035_rename_fix
branch
from
59b1409 to
8a6056d
Compare
mmeller-wikia
approved these changes
Feb 21, 2024
selfservice/hook/web_hook.go
Outdated
| validationErrs = append(validationErrs, schema.NewHookValidationError(msg.InstancePtr, "a webhook target returned an error", messages)) | ||
| } | ||
| } else { | ||
| for _, msg := range hookResponseFallback.Messages { |
There was a problem hiding this comment.
Nitpick: This for could be extracted to function.
IMO: It might be not worth the effort, because we would change this code soon after migration
There was a problem hiding this comment.
Yeah, I kept it simple, because it'll be deleted soon.
Co-authored-by: Mikołaj Meller <[email protected]>
Co-authored-by: Mikołaj Meller <[email protected]>
# Conflicts: # selfservice/hook/web_hook.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.