PLATFORM-9039 code review notes

Wikia · Feb 19, 2024 · 3b90cf7 · 3b90cf7
1 parent e6fd7cb
commit 3b90cf7
Showing 1 changed file with 4 additions and 15 deletions.
diff --git a/driver/registry_default.go b/driver/registry_default.go
@@ -83,7 +83,7 @@ type RegistryDefault struct {
 	rwl sync.RWMutex
 	l   *logrusx.Logger
 	c   *config.Config
-	rc  map[string]*retryablehttp.Client
+	rc  *sync.Map
 
 	ctxer contextx.Contextualizer
 
@@ -237,7 +237,7 @@ func (m *RegistryDefault) RegisterRoutes(ctx context.Context, public *x.RouterPu
 func NewRegistryDefault() *RegistryDefault {
 	return &RegistryDefault{
 		trc: otelx.NewNoop(nil, new(otelx.Config)),
-		rc:  map[string]*retryablehttp.Client{},
+		rc:  new(sync.Map),
 	}
 }
 
@@ -815,19 +815,8 @@ func (m *RegistryDefault) PrometheusManager() *prometheus.MetricsManager {
 }
 
 func (m *RegistryDefault) NamedHTTPClient(ctx context.Context, name string, opts ...httpx.ResilientOptions) *retryablehttp.Client {
-	var rc *retryablehttp.Client
-	m.rwl.RLock()
-	if cl, ok := m.rc[name]; ok {
-		m.rwl.RUnlock()
-		rc = cl
-	} else {
-		m.rwl.RUnlock()
-		rc = m.HTTPClient(ctx, opts...)
-		m.rwl.Lock()
-		m.rc[name] = rc
-		m.rwl.Unlock()
-	}
-	return rc
+	res, _ := m.rc.LoadOrStore(name, m.HTTPClient(ctx, opts...))
+	return res.(*retryablehttp.Client)
 }
 
 func (m *RegistryDefault) HTTPClient(ctx context.Context, opts ...httpx.ResilientOptions) *retryablehttp.Client {