Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Style/StringConcatenation rubocop violations and enable the check for it #6085

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Resolve Style/StringConcatenation rubocop violations and enable the check for it #6085

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c01b0b
enable Style/StringConcatenation rule for rubocop
bhushan354 Jan 3, 2025
f45afa8
replace string concatenation with string interpolation
bhushan354 Jan 3, 2025
f1c4401
Merge branch 'master' into str_concat_fix
bhushan354 Jan 3, 2025
990e067
move StringConcatenation rule to 'permanent exceptions' section
bhushan354 Jan 3, 2025
a214513
revert changes
bhushan354 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ Layout/HashAlignment:
Enabled: false # Hashes look uglier when corrected
Rails/I18nLocaleTexts:
Enabled: false # Generally the translations are done manually so most times many language translations will be missing while the fallback message is English
Style/StringConcatenation:
Enabled: false

########################
# Temporary exceptions #
Expand Down Expand Up @@ -171,8 +173,6 @@ Style/DateTime:
Enabled: false
Rails/ContentTag:
Enabled: false
Style/StringConcatenation:
Enabled: false
Style/OptionalBooleanParameter:
Enabled: false
Style/ExplicitBlockArgument:
Expand Down
Loading