fix:restored removed article to available articles

[shishiro26]

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This PR restores both self-assigned and admin-assigned articles back to the pool of available articles.
I have written a test case for the controller to ensure that the changes work as expected.

Screenshots

After:
https://github.com/user-attachments/assets/db77ecb3-734d-4693-94d2-cfd235297c90

Open questions and concerns

With this change, when removing an article, a dialog appears with the message: "Are you sure you want to delete this program?"

• Do we need to modify the dialog message to reflect the new functionality?

#5549

[shishiro26]

In this PR, I have added Ruby test cases for the unclaim method in the AssignmentsController.

The scenarios covered are as follows:

1. When the article is assigned to the user by the admin:
   • The admin removes the assignment.
   • https://github.com/user-attachments/assets/7bbd0d4e-bac7-4f56-9066-af09b595dc84
2. When the article is assigned to the user by the admin:
   • The user removes the assignment.
   • https://github.com/user-attachments/assets/392911db-789f-44dc-81c7-84f73232d7a6
3. When the article is self-assigned:
   • Either the user or the admin removes the self-assigned article.
   • https://github.com/user-attachments/assets/ea029f97-58a5-455c-996d-4d46ee9ee9a2

[shishiro26]

@ragesoss the test is passing locally in my system

[shishiro26]

@ragesoss, I'm not entirely sure, but the multiwiki_assignment_spec.rb test seems to be failing after the latest commit merge. Additionally, the account_requests_spec.rb test is failing both on my local setup and in the master branch. However, this failure appears to be unrelated to the changes I made.

[ragesoss]

@shishiro26 yes, i'm not sure why it started failing, but i'm going to look into it.

[ragesoss]

Does this implementation differentiate articles that started as Available Articles versus ones that the student chose via title without starting as an Available Article? I think we need this to only apply for ones that started as Available Articles.

[shishiro26]

I’m not sure if you’re referring to this one, sir

User:
https://github.com/user-attachments/assets/0cfa08ac-d75f-4f52-a223-a3c63a471ec9

If so, then yes, it doesn’t differentiate between the two. It removes both from the assigned ones and keeps them in the available articles, sir.

[shishiro26]

Sir, I would like to know if there is any user-specific association, such as a user_id or something similar, that tracks whether a particular person created or added an article. Is there an existing reference to identify the user who created or added the article? From the logs I’ve seen, there are references to users, but they seem to be related to assignments rather than article creation. If such an association doesn’t currently exist, would it be possible for me to add a user_id field to the articles table and link it to the user who created or added the article?

[ragesoss]

I think you could use Assignment#flags to keep track of whether an Assignment record began as an Available Article.

[shishiro26]

Sir, I believe there is no change in the flags field, as it remains NULL in both cases in the SQL database. There appears to be no update to Assignment.flags.

[ragesoss]

Right, you would need to implement that.

[shishiro26]

okay, sir! 😄

[shishiro26]

Could you please review this, sir? This is just a rough implementation. If this method looks fine, the unclaim method (which removes the article if it is not in the available articles pool, and if it is in the pool, the assignment is simply unclaimed and added back to the available articles), and if the assignment#flags are set correctly, I will refine the code and update the RSpec tests for the final version.

[ragesoss]

I will plan to review this next week.

[shishiro26]

Okay sir