Better handling of API errors from get_page_content

WikiEducationFoundation · Oct 11, 2017 · a791349 · a791349
1 parent 78fc974
commit a791349
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/student_greeting_checker.rb b/lib/student_greeting_checker.rb
@@ -43,7 +43,8 @@ def update_greeting_status
     private
 
     def talk_page_blank?
-      WikiApi.new(@wiki).get_page_content(@student.talk_page).blank?
+      # Non-existent pages will return '', but API errors will return nil
+      WikiApi.new(@wiki).get_page_content(@student.talk_page) == ''
     end
 
     def contributors_to_page(page_title)