Re-added dependency loop detection

pkg/duties/dutymanager.go

@@ -71,6 +71,9 @@ func (dm *DutyManager) runTasks(dryRun bool) error {
 		if len(taskToBeDone) > 0 {
 			//tasksRunInThisWave gets incremented for every task that enters preflight or execution during this iteration
 			tasksRunInThisWave := 0
+			//tasksDoingSomething indicates how many tasks are currently running in the background
+			//This needs to be done before we increment tasksRunInThisWave in order to ensure a task doesn't finish in the delta between increment and checking if tasks are running
+			tasksDoingSomething := len(tasksDoingSomething(tl))
 
 			for i := range taskToBeDone {
 				task := taskToBeDone[i]
@@ -84,9 +87,12 @@ func (dm *DutyManager) runTasks(dryRun bool) error {
 					}
 
 					//If one of the tasks dependencies failed, we can't execute this task
-					if k.status.State == TaskStateFailed || k.status.State == TaskStatePreFlightFailed {
+					if k.status.State == TaskStateFailed || k.status.State == TaskStatePreFlightFailed || k.status.State == TaskStateDependencyFailed {
 						task.setStatus(TaskStateDependencyFailed)
 						task.status.Error = ErrDependencyFailed
+
+						//Avoid dependency loop detection
+						tasksRunInThisWave++
 						break
 					}
 				}
@@ -114,6 +120,12 @@ func (dm *DutyManager) runTasks(dryRun bool) error {
 				}
 			}
 
+			//Check if we are stuck (loop dependencies or something like that)
+			if tasksRunInThisWave == 0 && tasksDoingSomething == 0 {
+				logError("Executing failed because of dependency loop", ErrDependencyLoop)
+				return ErrDependencyLoop
+			}
+
 		} else {
 			//Check if there as still tasks running
 			//Block current thread until we successfully processed all tasks