Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination_initial_offset setting #43

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Mar 22, 2024

Closes #42

@edgarrmondragon
Copy link
Contributor Author

cc @romulobruno you can try this in your meltano.yml with:

plugins:
  extractors:
  - name: tap-rest-api-msdk
    pip_url: 'tap-rest-api-msdk @ git+https://github.com/Widen/tap-rest-api-msdk@refs/pull/43/head'

@romulobruno
Copy link

It worked as expected after setting the variable pagination_initial_offset to 0.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 22, 2024 19:14
@jlloyd-widen jlloyd-widen self-requested a review March 26, 2024 15:19
@jlloyd-widen jlloyd-widen merged commit 9608e70 into Widen:main Mar 26, 2024
@edgarrmondragon edgarrmondragon deleted the feat-initial-offset branch March 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination offset is 1 instead of being configurable
3 participants