HighestWinRateForRole Functionality improvement #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RoleIdentifier#getHighestWinRateForRole()` method was throwing an exception when criteria was not met, an improvement was introduced, and now there is another method that can be called with a flag that will return an `Optional.empty()` when this scenario occurs. - `README.md` and `pom.xml` were updated with the latest version and are ready for the `release` process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HighestWinRateForRole Functionality improvement
RoleIdentifier#getHighestWinRateForRole()method was throwing an exception when criteria were not met, an improvement was introduced, and now there is another method that can be called with a flag that will return anOptional.empty()when this scenario occurs.README.mdandpom.xmlwere updated with the latest version and are ready for thereleaseprocess.