Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alliance #12

Merged
merged 18 commits into from
Feb 2, 2023
Merged

Alliance #12

merged 18 commits into from
Feb 2, 2023

Conversation

Sen-Com
Copy link
Contributor

@Sen-Com Sen-Com commented Feb 2, 2023

Description and Motivation

  • Adds alliance
  • Uses go 1.20
  • disables the check for blocked modules
  • linted markdown
  • fixed usage of custom bank keeper

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly go fmt path/to/your/package.

@faddat
Copy link
Collaborator

faddat commented Feb 2, 2023

jumping in.

@javiersuweijie
Copy link
Contributor

Will need to exclude the alliance module account from here as well when creating the bank keeper.

Alliance module needs access to transfer tokens directly to accounts. Will create a ticket to look into if we can work around this.

migaloo-chain/app/app.go

Lines 384 to 390 in b5c8c4d

app.BankKeeper = bankkeeper.NewBaseKeeper(
appCodec,
keys[banktypes.StoreKey],
app.AccountKeeper,
app.GetSubspace(banktypes.ModuleName),
app.ModuleAccountAddrs(),
)

@faddat faddat marked this pull request as ready for review February 2, 2023 13:02
@faddat faddat enabled auto-merge February 2, 2023 13:16
@faddat faddat disabled auto-merge February 2, 2023 14:03
@faddat faddat merged commit 9d885b6 into main Feb 2, 2023
@hoank101 hoank101 deleted the alliance branch March 22, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants