-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added explicit file ending to sh files #72
Conversation
Thanks for this! Did you run a re-normalization of the existing files with git add --renormalize . ? If you could and update the PR that'd be great, then we can get it merged |
yes ran this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
This is with reference to #64
When repo is clone, sometimes the line ending cause problems during docker build, so I have added gitattributes to define line ending on the sh files explicitly.
Also, I have just added a new line at the end of the .sh file and normalized them.