-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Domain 작성 #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨어요!
...jpamongo-review-domain/src/main/java/com/wypl/jpamongoreviewdomain/review/domain/Review.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
몇가지 질문이 있어서 확인 부탁드립니다!
|
||
@Getter | ||
public enum JpaErrorCode implements ServerErrorCode { | ||
ALREADY_DELETED_ENTITY(400, "JPA_001", "이미 삭제된 요소는 삭제할 수 없습니다."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
에러 메시지에서 혹시 요소
라고 표현하신 이유가 있을까요? 엔티티의 특정 필드 삭제보다는 엔티티 자체가 삭제된 경우에 대한 에러 메시지라고 생각이 들어서요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제 해당 내용이 결국은 클라이언트(사용자)에게 보이는데 노출되어도 괜찮을 정도로 메시지를 작성하고 있었습니다.
혹시 다른 메시지가 있으면 추천해 주실 수 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
명시적인건 "이미 삭제된 엔티티입니다" 정도로 생각했는데, 사용자에게 보이는 것을 고려하면 "이미 삭제된 데이터입니다"라는 식도 괜찮을 것 같네요 : )
...jpamongo-review-domain/src/main/java/com/wypl/jpamongoreviewdomain/review/domain/Review.java
Show resolved
Hide resolved
Resolvers: #5
📄 Image Server Jacoco Coverage Report
|
common/src/main/java/com/wypl/common/exception/GlobalErrorCode.java
Outdated
Show resolved
Hide resolved
📄 Image Server Jacoco Coverage Report
|
📑 개요
✅ PR 체크리스트
🚀 상세 작업 내용
Jpa Mongo Review Domain
해당 모듈에서는 JPA 및 Mongo 를 사용하므로 네이밍을
jpa-mongo-review-domain
로 작성하였습니다.해당 엔티티는 추후
Schedule.java
와 연관 관계가 필요하므로 주석으로 처리해두었습니다.📁 ETC